Skip to content

Potion Altar#892

Merged
LordIdra merged 29 commits into
masterfrom
balugaq/potion-altar
May 10, 2026
Merged

Potion Altar#892
LordIdra merged 29 commits into
masterfrom
balugaq/potion-altar

Conversation

@balugaq
Copy link
Copy Markdown
Collaborator

@balugaq balugaq commented Mar 14, 2026

No description provided.

@balugaq balugaq self-assigned this Mar 14, 2026
@balugaq balugaq linked an issue Mar 14, 2026 that may be closed by this pull request
Potion Altar #427
Closed
@balugaq balugaq marked this pull request as ready for review April 5, 2026 14:07
Seggan
Seggan requested changes Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Seggan Seggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the concept and the execution in the multiblock. Maybe add some particles or smth specifically for when it's going through the crafting cycle?

Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/resources/settings/potion_altar.yml Outdated
Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
@balugaq balugaq requested a review from Seggan April 11, 2026 15:28
@balugaq
Copy link
Copy Markdown
Collaborator Author

balugaq commented Apr 11, 2026

QQ20260411-231731.mp4

Also tested recipe-recovering

LordIdra
LordIdra requested changes Apr 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@LordIdra LordIdra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea and the visual implementation is really really nice

Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/PylonItems.java
Comment thread src/main/java/io/github/pylonmc/pylon/PylonItems.java Outdated
Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/resources/lang/en.yml Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java Outdated
Comment thread src/main/resources/lang/en.yml
Comment thread src/main/java/io/github/pylonmc/pylon/content/machines/simple/PotionAltar.java
Comment thread src/main/java/io/github/pylonmc/pylon/PylonItems.java
@LordIdra
Copy link
Copy Markdown
Contributor

LordIdra commented Apr 12, 2026

Also forgot to mention, the catalyst are quite expensive to REALLY expensive for being single-use items. I would make them significantly cheaper

@balugaq
Copy link
Copy Markdown
Collaborator Author

balugaq commented Apr 17, 2026

Also forgot to mention, the catalyst are quite expensive to REALLY expensive for being single-use items. I would make them significantly cheaper

Now simplified more I think: replace abyssal_catalyst to covalent_binder

@balugaq
Copy link
Copy Markdown
Collaborator Author

balugaq commented Apr 17, 2026

tested

@balugaq balugaq requested a review from LordIdra April 17, 2026 17:49
LordIdra
LordIdra requested changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@LordIdra LordIdra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think the ascendant ember recipe is still too expensive to be worth it, remove the shimmer dust 3 from the recipe? shimmer dust 3 is very annoying to make.

The potion altar should have its direction set with setMultiblockDirectional and should also be a RebarDirectionalBlock

Consider this approved once that is done

(Also I think it would be better if the potion altar catalysts used recipes and recipe processor instead but not going to request changes on that as the processor stuff is getting reworked soon anyway)

@balugaq
Copy link
Copy Markdown
Collaborator Author

balugaq commented Apr 18, 2026

Done.

by the way, a problem related to RebarTranslator:
QQ_1776497876287
This splash potion cannot be thrown out.

@balugaq balugaq requested a review from LordIdra April 18, 2026 07:39
@Seggan
Copy link
Copy Markdown
Member

Seggan commented Apr 20, 2026

This splash potion cannot be thrown out.

Just make an issue for it, I'll get to it at some point

Seggan
Seggan requested changes Apr 20, 2026
View reviewed changes
Comment thread src/main/java/io/github/pylonmc/pylon/content/building/Pedestal.java Outdated
Comment thread src/main/java/io/github/pylonmc/pylon/content/tools/base/PotionCatalyst.java Outdated
Comment thread src/main/resources/lang/en.yml Outdated
@balugaq balugaq mentioned this pull request Apr 25, 2026
Open
balugaq and others added 4 commits April 25, 2026 11:20
@balugaq balugaq requested a review from Seggan April 25, 2026 04:16
@LordIdra LordIdra merged commit bbd3cd3 into master May 10, 2026
1 check failed
@LordIdra LordIdra deleted the balugaq/potion-altar branch May 10, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LordIdra LordIdra LordIdra approved these changes

@Seggan Seggan Awaiting requested review from Seggan

Assignees

@balugaq balugaq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Potion Altar

3 participants

@balugaq @LordIdra @Seggan